bluekitchen / btstack

Dual-mode Bluetooth stack, with small memory footprint.
http://bluekitchen-gmbh.com
Other
1.74k stars 618 forks source link

too few arguments to function 'hci_event_create_from_template_and_arglist' #577

Closed zenkoo closed 8 months ago

zenkoo commented 8 months ago

../../chipset/cinnamon/controller.c:168:23: error: too few arguments to function 'hci_event_create_from_template_and_arglist' 168 | uint16_t length = hci_event_create_from_template_and_arglist(hci_outgoing_event, event, argptr); | ^~~~~~~~~~ In file included from ../../chipset/cinnamon/controller.c:54: ../../src/hci_event.h:78:10: note: declared here 78 | uint16_t hci_event_create_from_template_and_arglist(uint8_t hci_buffer, uint16_t buffer_size, const hci_event_t event, va_list argptr); | ^~~~~~~~~~

mringwal commented 8 months ago

Thanks for reporting. It needed the buffer size. Fixed in 478f65a on branch develop. Does it build for you now?

Nuts-Underline commented 6 days ago

nop. having other error with hci_event_create_from_template_and_arglist line 168

../../chipset/cinnamon/controller.c: In function 'transport_emit_hci_event':
../../chipset/cinnamon/controller.c:168:86: warning: passing argument 2 of 'hci_event_create_from_template_and_arglist' makes integer from pointer without a cast [-Wint-conversion]
  168 |     uint16_t length = hci_event_create_from_template_and_arglist(hci_outgoing_event, event, argptr);
      |                                                                                      ^~~~~
      |                                                                                      |
      |                                                                                      const hci_event_t * {aka const struct <anonymous> *}
In file included from ../../chipset/cinnamon/controller.c:54:
../../src/hci_event.h:78:83: note: expected 'uint16_t' {aka 'short unsigned int'} but argument is of type 'const hci_event_t *' {aka 'const struct <anonymous> *'}
   78 | uint16_t hci_event_create_from_template_and_arglist(uint8_t *hci_buffer, uint16_t buffer_size, const hci_event_t *event, va_list argptr);
      |                                                                          ~~~~~~~~~^~~~~~~~~~~
../../chipset/cinnamon/controller.c:168:93: error: incompatible type for argument 3 of 'hci_event_create_from_template_and_arglist'
  168 |     uint16_t length = hci_event_create_from_template_and_arglist(hci_outgoing_event, event, argptr);
      |                                                                                             ^~~~~~
      |                                                                                             |
      |                                                                                             va_list {aka __va_list}
In file included from ../../chipset/cinnamon/controller.c:54:
../../src/hci_event.h:78:115: note: expected 'const hci_event_t *' {aka 'const struct <anonymous> *'} but argument is of type 'va_list' {aka '__va_list'}
   78 | uint16_t hci_event_create_from_template_and_arglist(uint8_t *hci_buffer, uint16_t buffer_size, const hci_event_t *event, va_list argptr);
      |                                                                                                ~~~~~~~~~~~~~~~~~~~^~~~~
../../chipset/cinnamon/controller.c:168:23: error: too few arguments to function 'hci_event_create_from_template_and_arglist'
  168 |     uint16_t length = hci_event_create_from_template_and_arglist(hci_outgoing_event, event, argptr);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../chipset/cinnamon/controller.c:54:
../../src/hci_event.h:78:10: note: declared here
   78 | uint16_t hci_event_create_from_template_and_arglist(uint8_t *hci_buffer, uint16_t buffer_size, const hci_event_t *event, va_list argptr);

building stm32-l476rg-nucleo-sx1280 and nrf5-cinnamon with 1.6.1 rel. and master branch

mringwal commented 6 days ago

Sorry, we've missed that initially. It has been fixed on develop branch, in commit cf1c3df9. Next release probably before Christmas.

Nuts-Underline commented 5 days ago

switched to develop branch having other issue now #644 (stm32-l476rg-nucleo-sx1280 is OK)