search

bluekitchen / btstack

Dual-mode Bluetooth stack, with small memory footprint.
http://bluekitchen-gmbh.com
Other
1.74k stars 618 forks source link

SUPPORTED_HCI_COMMAND_LE_SET_EXTENDED_ADVERTISING_ENABLE is defined incorrectly #624

Closed thewierdnut closed 3 months ago

thewierdnut commented 3 months ago

Describe the bug

SUPPORTED_HCI_COMMAND_LE_SET_EXTENDED_ADVERTISING_ENABLE defined as byte 36, bit 6, when it is supposed to be bit 5.

(I'm referencing the table in the Core bluetooth 5.2 spec, Vol 4, Part E, 6.27)

To Reproduce

The chipset I'm working with doesn't implement either bit, so it doesn't really matter to me... just thought you would want to know.

Expected behavior

Should be bit 5, not bit 6.

HCI Packet Logs

None

Environment: (please complete the following information):

Additional context I haven't tried using this yet, just rooting through the code, comparing it to the spec.

mringwal commented 3 months ago

Thanks for spotting this. It's fixed on develop branch now.