bluelinelabs / Conductor

A small, yet full-featured framework that allows building View-based Android applications
Apache License 2.0
3.9k stars 343 forks source link

router.setBackstack pushes only first controller #604

Closed TikTak123 closed 4 years ago

TikTak123 commented 4 years ago

Before update from com.bluelinelabs:conductor:3.0.0-rc2 everything worked well

Conductor version: implementation 'com.bluelinelabs:conductor:3.0.1-SNAPSHOT'

Sample code:

router.setBackstack(
            arrayListOf(
                RouterTransaction.with(MainMenuController(Constants.MAIN_TAB)),
                RouterTransaction.with(MyMelodyController(ringtone))
            ),
            HorizontalChangeHandler()
        )
EricKuck commented 4 years ago

I'm not able to reproduce this issue. Setting a backstack with multiple items works fine for me. Is it possible to get a small demo together for this?

TikTak123 commented 4 years ago

I use setBackstack in two places

In first place after this I see only first controller

router.setBackstack(
    arrayListOf(
        RouterTransaction.with(MainMenuController(Constants.MAIN_TAB)),
        RouterTransaction.with(MyMelodyController(ringtone))
    ),
    HorizontalChangeHandler()
)

In second place In this situation everything is OK

router.setBackstack(
    arrayListOf(
        RouterTransaction.with(MainMenuController(Constants.MAIN_TAB)),
        RouterTransaction.with(QuizController())
    ),
    HorizontalChangeHandler()
)

I will try to write sample app

TikTak123 commented 4 years ago

I find out why this happen. My coworker added change in code base and he did mistake and for that reason our application works strange and crashes.

TikTak123 commented 4 years ago

Thank you