DynamicFieldType: restore TypeConverter lookup

bluelinelabs / LoganSquare

Screaming fast JSON parsing and serialization library for Android.

Apache License 2.0

3.21k stars 306 forks source link

DynamicFieldType: restore TypeConverter lookup #144

Closed talklittle closed 8 years ago

talklittle commented 8 years ago

This was changed between LoganSquare 1.3.3 and 1.3.4.

Reverting this change fixes the compile-time error.

fixes GH-118

EricKuck commented 8 years ago

Thanks @talklittle! Will be releasing an update that includes this within a few hours.

EricKuck commented 8 years ago

I actually ended up reverting this PR and fixing it a different way. Since creating TypeConverters can theoretically be expensive, the new change in 1.3.7 should ensure that they're only ever created once. If you have any issues with 1.3.7 vs. 1.3.6, please let me know.

talklittle commented 8 years ago

@EricKuck Thanks! 1.3.7 works great. Tested with ProGuard also.