search

bluemania / wow_auctions

Use WoW addon data to analyze optimal policies for auction buying and selling
MIT License
2 stars 2 forks source link

Updates GitHub Actions setup-python #184

Open amarvin opened 1 year ago

amarvin commented 1 year ago

Proposed Changes

amarvin commented 1 year ago

Awesome work on this repo! I thought it'd be cool to help try to get the CI/CD pipelines working again. The last failed one is too old to show the log anymore, so I opened this PR to get a new run of the CI/CD pipeline that then would show an error to further troubleshoot.

amarvin commented 1 year ago

LGTM thanks!

Cool! Looks like "this workflow requires approval from a maintainer" - can you kick off the CI/CD?

amarvin commented 1 year ago

Hmm, I was expecting the test workflow to run. Maybe I can get it to run in PRs.

amarvin commented 1 year ago

Thanks, that ran the test workflow and showed the syntax for updating pip needed a fix. Can you approve the workflow again?

amarvin commented 1 year ago

The last workflow error is a known issue with old versions of poetry, and is resolved with: https://github.com/python-poetry/poetry/issues/6300#issuecomment-1233211156. Can you approve the workflow again?

amarvin commented 1 year ago

We're still getting workflow errors, but at least a new error now. This one might get resolved by updating nox-poetry (https://github.com/python-poetry/poetry/issues/3472#issuecomment-754853589).

amarvin commented 1 year ago

Wow, the tests ran!

amarvin commented 1 year ago

Seems like there's an issue within numpy used by pandas during test_e2e, which can be resolved by updating numpy (https://stackoverflow.com/a/66138833/6068036).

bluemania commented 1 year ago

OK just send a message here if you want me to come back and approve/rerun.

It was a fun project while i was working on it and i'm happy that you have interest in it.

I think most of the coding work here was to develop the data infrastructure and WoW UI interfacing; but there's a lot of potential to plug in different policies