bluemixgaragelondon / cf-blue-green-deploy

Cloud Foundry CLI plugin for zero downtime deploys
Apache License 2.0
139 stars 61 forks source link

FR: Support new buildpacks key in manifest.yml #83

Open gteirlinck opened 5 years ago

gteirlinck commented 5 years ago

New version of the CF CLI supports multiple buildpacks in manifest.yml with the buildpacks array:

buildpacks:
- buildpack1
- buildpack2

However it seems that the same is not yet supported by blue-green-deploy. Here is the error I receive when I try to use cf bgd -f manifest.yml with a multiple buildpacks manifest:

Could not push new version - Error reading manifest file:
The following manifest fields cannot be used with legacy push: buildpacks

Would it be possible to add support for new manifest fields in a new version of the plugin?

afomi commented 5 years ago

This might be related to the underlying cf cli plugin architecture, moreso than this plugin.

For reference: https://www.pivotaltracker.com/n/projects/892938/stories/160460938, https://github.com/concourse/cf-resource/issues/62

UPDATE: I also found that zdt or zero-downtime-deploy is now offered via the CF CLI. https://docs.cloudfoundry.org/devguide/deploy-apps/rolling-deploy.html

Srinivas289 commented 5 years ago

Any work arounds ? Can we use multiple buildpacks with this plugin ?

phpbg commented 4 years ago

Hi, any update on this?

peterpoliwoda commented 4 years ago

Having this issue in Travis. Honestly not an issue yet because it just says it's deprecated but sooner or later support for the legacy - buildpack will we stopped and we won't be able to deploy any more.

sachatelgenhof commented 3 years ago

Just experienced the same thing also. My deployment simply stopped/failed:

Could not push new version - Error reading manifest file:
The following manifest fields cannot be used with legacy push: buildpacks
Unable to push the instance live. Aborting.

I can work around it possibly bypassing the blue-green-deploy, however would be nice this would be supported.

devswapnil commented 3 years ago

Please refer this documentation: https://docs.cloudfoundry.org/buildpacks/use-multiple-buildpacks.html

peterpoliwoda commented 3 years ago

This is great but that's not going to solve the fact that the manifest eventually is going to be completely broken. This needs an update to the travis plugin