v0.22.0 breaks webrtcICEUDPMuxAddress

mrlt8 commented 1 year ago

Which version are you using?

v0.22.0

Which operating system are you using?

[ ] Linux amd64 standard
[x] Linux amd64 Docker
[ ] Linux arm64 standard
[x] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue

webrtcICEUDPMuxAddress was working previously, but seems to be broken after upgrading to v0.22.0. Switching to webrtcICETCPPMuxAddress with -p 8189:8189 still works as expected.

Describe how to replicate the issue

docker run -p 8889:8889 -p 8189:8189/udp \
-e MTX_PATHS_TEST_SOURCE=rtsp://test-server:8554/stream \
-e MTX_WEBRTCICEHOSTNAT1TO1IPS=10.0.0.111 \
-e MTX_WEBRTCICEUDPMUXADDRESS=:8189 \
aler9/rtsp-simple-server

Did you attach the server logs?

 DEB [WebRTC] [conn 172.17.0.1:44760] peer connection state: closed
 INF [WebRTC] [conn 172.17.0.1:44760] closed (deadline exceeded)
 DEB [WebRTC] [conn 172.17.0.1] [s->c] HTTP/1.1 404 Not Found
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Server: mediamtx

Did you attach a network dump?

no

EDIT:

Works as expected when rolling back down to v0.21.6:

docker run -p 8889:8889 -p 8189:8189/udp \
-e RTSP_PATHS_TEST_SOURCE=rtsp://test-server:8554/stream \
-e RTSP_WEBRTCICEHOSTNAT1TO1IPS=10.0.0.111 \
-e RTSP_WEBRTCICEUDPMUXADDRESS=:8189 \
aler9/rtsp-simple-server:v0.21.6

aler9 commented 1 year ago

Hello, i've investigated the issue and it turned out that it's a regression in pion/ice. I've sent a PR with a fix here: https://github.com/pion/ice/pull/550

aler9 commented 1 year ago

added in MediaMTX v0.22.1

github-actions[bot] commented 9 months ago

This issue is being locked automatically because it has been closed for more than 6 months. Please open a new issue in case you encounter a similar problem.

bluenviron / mediamtx