search

bluenviron / mediamtx

Ready-to-use SRT / WebRTC / RTSP / RTMP / LL-HLS media server and media proxy that allows to read, publish, proxy, record and playback video and audio streams.
MIT License
10.88k stars 1.41k forks source link

webrtc: fix deadlock when a WHEP source fails (#3062) (#3108) #3110

Closed RouquinBlanc closed 4 months ago

RouquinBlanc commented 4 months ago

Tentative for fixing #3108.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.58%. Comparing base (dd3b268) to head (9fa8b3f).

Files Patch % Lines
internal/protocols/webrtc/peer_connection.go 77.77% 2 Missing :warning:
internal/protocols/webrtc/whip_client.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3110 +/- ## ========================================== + Coverage 55.10% 55.58% +0.48% ========================================== Files 150 150 Lines 16819 16822 +3 ========================================== + Hits 9268 9351 +83 + Misses 6824 6733 -91 - Partials 727 738 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aler9 commented 4 months ago

Thanks for reporting the issue and for posting the patch. I improved performance and added tests. This has been merged, thanks!

github-actions[bot] commented 3 months ago

This issue is mentioned in release v1.7.0 🚀 Check out the entire changelog by clicking here