search

bluenviron / mediamtx

Ready-to-use SRT / WebRTC / RTSP / RTMP / LL-HLS media server and media proxy that allows to read, publish, proxy, record and playback video and audio streams.
MIT License
10.88k stars 1.41k forks source link

Add option for ICE servers to be client only #3164

Closed dbason closed 3 months ago

dbason commented 3 months ago

Fixes #3145

The config update will not change the default behaviour. It does however allow the asymmetric model. This is how LiveKit uses TURN servers for example.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.69%. Comparing base (ac14a2f) to head (0c72f7b). Report is 7 commits behind head on main.

Files Patch % Lines
internal/servers/webrtc/server.go 47.36% 9 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3164 +/- ## ========================================== + Coverage 55.65% 55.69% +0.03% ========================================== Files 151 151 Lines 16874 16875 +1 ========================================== + Hits 9391 9398 +7 + Misses 6744 6738 -6 Partials 739 739 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dbason commented 3 months ago

I think there might be a race condition in the failing test. I have noticed that one other open PR is also failing on the same thing.

aler9 commented 3 months ago

merged, thanks!

github-actions[bot] commented 3 months ago

This issue is mentioned in release v1.7.0 🚀 Check out the entire changelog by clicking here