Closed aler9 closed 2 months ago
Attention: Patch coverage is 34.28571%
with 92 lines
in your changes are missing coverage. Please review.
Project coverage is 55.87%. Comparing base (
665e11a
) to head (16baf95
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This issue is mentioned in release v1.7.0 🚀 Check out the entire changelog by clicking here
Hi, a question about the cons: What do you mean by "generation is slower"? Is a file created that concatenates all the segments? On disk or in RAM? or is it necessary to read all the segments to get the total size without creating a temporary file? Is the slowness proportional to the length of the requested video?
Thanks, Paolo
What do you mean by "generation is slower"? Is a file created that concatenates all the segments? On disk or in RAM? or is it necessary to read all the segments to get the total size without creating a temporary file? Is the slowness proportional to the length of the requested video?
The slowness is caused by the fact that in standard MP4s there is a single list that contains all samples. Therefore, all segments must be scanned and their samples have to be parsed before the playback file can be served.
Yes, the slowness is proportional to the length of the requested video.
In fragmented MP4 on the other hand there are multiple, small lists of samples, and these are concatenated them together along with the sample content. Therefore, the playback file can be generated as soon as the first segment is scanned.
Description
This PR adds the mp4 (standard MP4) output format to the playback server, in additional to the existing fMP4 (fragmented MP4) output format.
Pros of standard MP4 with respect to fragmented MP4
Cons
Usage
Add
format=mp4
to paths in playback server:Nightly binaries
https://github.com/bluenviron/mediamtx/actions/runs/8621626444
TODO