search

bluenviron / mediamtx

Ready-to-use SRT / WebRTC / RTSP / RTMP / LL-HLS media server and media proxy that allows to read, publish, proxy, record and playback video and audio streams.
MIT License
10.74k stars 1.4k forks source link

fix support for JWT authentication in API, metrics, playback, pprof #3253

Closed rfscheidt closed 2 months ago

rfscheidt commented 2 months ago

I've made some modifications related to JWT authentication that I would like to bring to your attention. It appears that token validation was not being performed in the methods listed below. Additionally, I attempted to integrate it with HLS, but encountered some issues. It might be beneficial to review these changes to ensure everything is functioning as expected.

Modified Files:

internal/api/api.go internal/metrics/metrics.go internal/playback/server.go internal/pprof/pprof.go

Your feedback and review on these changes would be greatly appreciated. Please let me know if there are any concerns or if further adjustments are needed.

Thank you for your attention to this matter.

rfscheidt commented 2 months ago

@aler9 do you have time do review this PR?

aler9 commented 2 months ago

i added tests and merged, thanks!

github-actions[bot] commented 2 months ago

This issue is mentioned in release v1.8.0 🚀 Check out the entire changelog by clicking here