bluenviron / mediamtx

Ready-to-use SRT / WebRTC / RTSP / RTMP / LL-HLS media server and media proxy that allows to read, publish, proxy, record and playback video and audio streams.
MIT License
10.69k stars 1.39k forks source link

Make webrtcHandshakeTimeout and webrtcTrackGatherTimeout configurable #3404

Closed jwalton closed 1 month ago

jwalton commented 1 month ago

Describe the feature

I'm running into an issue where my WebRTC client is taking a little too long to complete the timeout. We end up hitting the webrtcHandshakeTimeout, which kills the connection, then my client tries again, but fails again, and we end up in this loop of doom never playing video, but it could be solved if we could bump up the timeout a little.

So I'd like to raise a PR to make this configurable, but I'm wondering if you would prefer to see these added to the Path struct (so they could be configured per-path) or to the top level Conf struct? I'm inclined towards the Conf struct, as it seems unlikely anyone would ever want to configure these path-by-path.

aler9 commented 1 month ago

fixed by #3406

github-actions[bot] commented 2 weeks ago

This issue is mentioned in release v1.8.3 🚀 Check out the entire changelog by clicking here