Save a hash of the hls.js release

bluenviron / mediamtx

Ready-to-use SRT / WebRTC / RTSP / RTMP / LL-HLS media server and media proxy that allows to read, publish, proxy, record and playback video and audio streams.

MIT License

10.67k stars 1.39k forks source link

Save a hash of the hls.js release #3464

Closed bouk closed 1 week ago

bouk commented 2 weeks ago

This ensures the downloaded hls.js matches exactly and removes a dependency on cdn.jsdelivr.net

It also makes it easier for the nixpkgs version of mediamtx to get the hls.min.js updates, because right now this needs to be done manually

aler9 commented 1 week ago

This has been merged, thanks.

Regarding the NixOS problem, in my opinion it has been fixed in the wrong way, since the proper solution consists into adding go generate to the package building process. Command go generate was introduced in order to run any pre-compilation step by using a single, standard, command. If pre-compilation steps are instead embed into the package and run manually, there's no guarantee that the software will compile correctly in the future.