search

bluenviron / mediamtx

Ready-to-use SRT / WebRTC / RTSP / RTMP / LL-HLS media server and media proxy that allows to read, publish, proxy, record and playback video and audio streams.
MIT License
11.64k stars 1.47k forks source link

Make `go install github.com/aler9/rtsp-simple-server@latest` work #777

Closed maruel closed 2 years ago

maruel commented 2 years ago

Describe the feature

go install is a great way to install go executables. It's fast and safe. We can use version number when needed. Since this project already uses semver git tags, it should just work.

Running go install github.com/aler9/rtsp-simple-server@latest currently fails due to the rewrite directive, here's the output locally:

go: downloading github.com/aler9/rtsp-simple-server v0.17.13
go install: github.com/aler9/rtsp-simple-server@latest (in github.com/aler9/rtsp-simple-server@v0.17.13):
        The go.mod file for the module providing named packages contains one or
        more replace directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

It has been the case since March 2021; https://github.com/aler9/rtsp-simple-server/commit/186a91800a684922efe4f7d1f3367144e9604002

maruel commented 2 years ago

There's a workaround to install from sources in the meantime; do a local clone:

git clone https://github.com/aler9/rtsp-simple-server
cd rtsp-simple-server
git checkout v0.17.13
go install .
aler9 commented 2 years ago

Hello, this would be nice to support, but replace directives are quite useful to solve important issues, since they allow to temporarily / permanently replace external dependencies, and i can't forbid them.

Maybe you can open an issue in the Golang repository and ask the maintainers to allow go install and replace to coexist.

maruel commented 2 years ago

My question was indirectly: why no attempt to do a PR upstream was done?

https://github.com/notedit/rtmp/compare/master...aler9:master

aler9 commented 2 years ago

Usually there's no time to wait for a PR to get merged. Furthermore, the changes in the RTMP repository are not meant to be merged into master.

github-actions[bot] commented 1 year ago

This issue is being locked automatically because it has been closed for more than 6 months. Please open a new issue in case you encounter a similar problem.