search

bluepines / slick53

Slick New Python Interface for AWS Route53
MIT License
36 stars 5 forks source link

module-level functions expect "self" as argument #1

Closed garnaat closed 13 years ago

garnaat commented 13 years ago

The module-level functions like create_zone, get_zones, etc. are expecting "self" as an argument even though they are not class methods.

bluepines commented 13 years ago

The module level functions are actually bound to the class "boto.route53.connection.Route53Connection" a few lines later:

Route53Connection.get_zones = get_zones
Route53Connection.get_zone = get_zone
Route53Connection.create_zone = create_zone

There is also this line at the top of the module: 

__all__ = []

Which means that none of those functions should be importable from the module level.

In short, I used the technique of Runtime Class Modification (affectionately called "monkey-patching") to extend the functionality of the current boto route53 interface. And by extend the functionality, I really just mean simplify some of the basic operations.

I realize that the implementation code may be unclear, but I was more or less striving for a clean interface from the user's perspective.

Hopefully, this clears things up.

-- Brad

garnaat commented 13 years ago

Ah, I see. You are monkey-patching the Route53Connection class. Now I understand. I just didn't read through the code thoroughly enough the first time.

It may be useful to integrate this into boto itself at some point. Let me know if that is something you are interested in. I'll close this issue now. Thanks.

bluepines commented 13 years ago

Yes, I would definitely be interested in integrating this into boto. Send me an email with some information regarding your development process and coding guidelines and I would be happy to integrate this into a pull request.

garnaat commented 13 years ago

Hi -

Have you seen this?

https://github.com/mariusv/Area53

Someone pointed it out to me and then, after looking at it a bit, it seemed to be almost a direct copy of your code. Weird.

Mitch

On Fri, Oct 14, 2011 at 3:19 PM, Brad Carleton < reply@reply.github.com>wrote:

Yes, I would definitely be interested in integrating this into boto. Send me an email with some information regarding your development process and coding guidelines and I would be happy to integrate this into a pull request.

Reply to this email directly or view it on GitHub: https://github.com/bluepines/slick53/issues/1#issuecomment-2410369

bluepines commented 13 years ago

Hi Mitch,

Thanks for pointing that out. He sure did copy the whole thing except that he changed it to say that he wrote it. He also copied my blog that I wrote to introduce the library and pasted it into his Wordpress blog.

I looked at another random blog on his Wordpress site and it appeared to be copied from someone else too.

Not sure what he is up to. Probably just some bored kid, but at least he has good taste in open source projects :)

-- Brad

On Tue, 2011-10-25 at 18:56 -0700, Mitch Garnaat wrote:

Hi -

Have you seen this?

https://github.com/mariusv/Area53

Someone pointed it out to me and then, after looking at it a bit, it seemed to be almost a direct copy of your code. Weird.

Mitch

On Fri, Oct 14, 2011 at 3:19 PM, Brad Carleton < reply@reply.github.com>wrote:

Yes, I would definitely be interested in integrating this into boto. Send me an email with some information regarding your development process and coding guidelines and I would be happy to integrate this into a pull request.

Reply to this email directly or view it on GitHub: https://github.com/bluepines/slick53/issues/1#issuecomment-2410369