search

blueprint-freespeech / ricochet-build

Repo for building ricochet-refresh
https://github.com/blueprint-freespeech/ricochet-refresh
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Replace linux_cross with add_architecture #21

Closed NoisyCoil closed 2 months ago

NoisyCoil commented 3 months ago

As described in PR #19, this PR eliminates linux_cross (currently unused in reality) in favor of an add_architecture variable, better named to explain its purpose and implemented correctly.

NoisyCoil commented 3 months ago

Before going ahead with this, please let me check that the changes don't trigger unnecessary rebuilds of the i386 toolchain. Having implemented correctly linux_cross may have this side effect (in which case I must remove the just-replaced add_architecture from that target).

NoisyCoil commented 3 months ago

All fine. The rebuilds are avoided by various target replacements. I confirm that this PR doesn't change anything functionally. (Also, removing add_architecture would not have been a good fix in any case as it would have prevented from actually adding the i386 architecture in containers which do need it).

morganava commented 2 months ago

Thanks @NoisyCoil !

NoisyCoil commented 2 months ago

No problem! Rebasing the other MR on this one.