blueprint-freespeech / ricochet-refresh

Anonymous peer-to-peer instant messaging
https://www.ricochetrefresh.net
Other
162 stars 27 forks source link

Crash when proxy is selected but no settings set #63

Closed morganava closed 3 years ago

morganava commented 3 years ago

In the Tor configuration window, if you select a Proxy type but do not fill in any parameters and then hit connect button, Ricochet-Refresh crashes.

This happens because the tego library call to set the proxy info will return an error when attempting to validate the parameters, which causes an exception to be thrown in the caller which triggres a segfault. We need to validate these params, or handle the exception at the libtego_ui call-site.

morganava commented 3 years ago

Fixed in https://github.com/m-simonelli/ricochet-refresh/commit/a976fe2a84787ded85c21cd567d1bb4aee48b555