Patch for /PHP/trunk/test/tests.xml

blueprintmrk / isemail

Automatically exported from code.google.com/p/isemail

0 stars 0 forks source link

Patch for /PHP/trunk/test/tests.xml #30

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

The "obs-FWS" production reads "obs-FWS         =   1*WSP *(CRLF 1*WSP)" - so 
obsolete whitespace must begin with a whitespace character (not CRLF). Thus as 
the tests are currently written I would expect the category to be ISEMAIL_ERR.

Original issue reported on code.google.com by j...@fogcreek.com on 6 Aug 2012 at 1:57

Attachments:

tests.xml.patch

GoogleCodeExporter commented 9 years ago

Thanks for your patch. Could you tell me which RFC you are quoting from?

Original comment by dominic....@gmail.com on 6 Aug 2012 at 9:53

Changed state: Started

GoogleCodeExporter commented 9 years ago

I agree with this. From RFC 5322:

FWS             =   ([*WSP CRLF] 1*WSP) /  obs-FWS

obs-FWS         =   1*WSP *(CRLF 1*WSP)

Although (non-obsolete) FWS can start with CRLF, it can only have a 
carriage-return/line-feed pair the once, and as the tests have this twice, it 
is clearly obs-FWS which must start with one or more WSP.

Original comment by mich...@squiloople.com on 6 Aug 2012 at 11:29

GoogleCodeExporter commented 9 years ago

Hmm, on thinking about this a little longer, it seems that I'm wrong after all. 
I was originally quoting from RFC 5322.

I didn't read this errata: 
http://www.rfc-editor.org/errata_search.php?rfc=5322&eid=1908 , which states 
that

obs-FWS         =   1*([CRLF] WSP)

In that case, this test would be correct. (Excellent job with these tests!)

Original comment by j...@fogcreek.com on 6 Aug 2012 at 5:17