search

bluerail / twitter-bootstrap-rails-confirm

Confirm dialogs using Twitter Bootstrap
https://bluerail.nl
MIT License
85 stars 34 forks source link

auto-detect Bootstrap version #24

Closed Nowaker closed 9 years ago

Nowaker commented 9 years ago

It's unhandy to define a different version for BS3. The module could check bootstrap-sass and twitter-bootstrap-rails gems to determine the version. https://stackoverflow.com/questions/2954279/how-do-you-check-the-gem-version-in-ruby-at-runtime

rvanlieshout commented 9 years ago

I like this. We'll make it happen!

rvanlieshout commented 9 years ago

Ok. We've created something. It doesn't detect the gem version because this gem doesn't depend on it. You just have to have Bootstrap loaded and it really doesn't matter how you do that. It'll use some javascript to determine the version loaded at runtime.

Could you give the version in master a go?

Nowaker commented 9 years ago

OK, give me two days to check it out in https://github.com/virtkick/virtkick-webapp. Thanks.

rvanlieshout commented 9 years ago

Take your time

Nowaker commented 9 years ago

2 days equals 5 but anyways. ;) Works OK in my Bootstrap 3 project so I presume autodetection works like a charm. Thanks!