<s>Rails 5.1<s> rails-ujs support

bluerail / twitter-bootstrap-rails-confirm

Confirm dialogs using Twitter Bootstrap

https://bluerail.nl

MIT License

85 stars 34 forks source link

<s>Rails 5.1<s> rails-ujs support #34

Open joseramonc opened 6 years ago

joseramonc commented 6 years ago

Rails 5.1 shows default confirm dialog

rvanlieshout commented 6 years ago

Ah. They really did change a lot in Rails 5.1. We'll try to get this resolved

rvanlieshout commented 6 years ago

In rails-ujs (actionview/app/assets/javascripts/features/confirm.coffee) they bind an anonymous function to document that calls a local allowAction and not $.rails.allowAction (or Rails.allowAction).

It'll be hard to get this fixed without a change in that file.

More to follow

rvanlieshout commented 5 years ago

Did research: we should use something other then data-confirm (e.g. data-confirm-bs)