search

bluerail / twitter-bootstrap-rails-confirm

Confirm dialogs using Twitter Bootstrap
https://bluerail.nl
MIT License
85 stars 34 forks source link

Convert CoffeeScript to JavaScript #37

Closed mftaff closed 6 years ago

mftaff commented 6 years ago

Hey guys, I am using rails 5 without coffescript installed.

Would it be possible to add this branch to the project so that people would have the option of installing the gem from the no-coffeescript branch?

Thanks!!

rvanlieshout commented 6 years ago

@shkm, this replaces our coffee script version. Do we want that? I guess there is no reason to have a dependency on coffee script for this small bit of code

shkm commented 6 years ago

Yeah, assuming it all works then I don't see why we'd want to use coffeescript in master either.

mftaff commented 6 years ago

@shkm I have been using the it and it seems to work, but I haven't done any kind of testing to ensure all cases. That may be a job better suited to someone who is more familiar with the source code :-)

mftaff commented 6 years ago

Side Note: the only change made was - converting the coffeescript to javascript. IE there should be no practical difference in terms of functionality.

rvanlieshout commented 6 years ago

I’ll update documentation and add this ASAP