Closed nishinohi closed 3 years ago
I have confirmed that this issue does not occur in master v1.0.90
.
I don't understand the behavior of FindTargetBuffer ()
, but if it is not a serious problem, you could close this issue.
Thank you.
Hello,
glad it was solved. I am currently on vacation. I will leave the issue open and will follow up with some information on the method once I am working again.
Marius
Hi, the FindTargetBuffer method is meant to put all potential partners for a connection into a list. The clustering algorithm will then select the best partner from this list every once in a while. "Space" simply means an entry in this list. It is first looking if an entry for that node already exists and can be updated, then for an empty slot to fit in the data, etc,....
sender == 0 was simply used to check if the slot in the list is empty or not so that it does not need to do a full memory compare.
I'll close the ticket but feel free to reopen it if sth. is unclear
I set
highToLowDiscoveryTimeSec
to 30 sec and tried to see if the Discovery state changed from HIGH to LOW. However, it does not change to LOW becauseKeepHighDiscoveryActive()
is called at intervals shorter than 30 seconds.KeepHighDiscoveryActive()
is called from the Node module'sFindTargetBuffer()
, but I'm not sure why it's called so often because I'm not sure what this method does.I would like to know the role of
FindTargetBuffer()
, meaning ofspace
in the comment ofFindTargetBuffer()
and what kind of situation it is whentargetBuffer->payload.sender
is 0.