rm -r in overlay_flush?

bluerider / liveroot

Initcpio hooks for overlayfs ontop of root

BSD 3-Clause "New" or "Revised" License

79 stars 13 forks source link

Closed louis-ad closed 7 years ago

louis-ad commented 8 years ago

Looking at the overlay_flush script, these 2 lines worry me: umount /run/oroot; rm -r /run/oroot;

if the unmounting fails for whatever reason... the script deletes your mounted "root" filesystem. That sounds like it's very safe!

bluerider commented 8 years ago

I guess I could replace ";' with "&&". This would ensure the directory wouldn't be removed if unmounts failed.

bluerider commented 7 years ago

Issue fixed with be50c417a57d7dffd73511086581f023e393b892