blueriver / MuraGoogleSitemaps

Google Sitemap plugin for Mura CMS
Apache License 2.0
5 stars 11 forks source link

Scheduled task failing under Mura 7.1 #25

Open IvanRotrekl opened 5 years ago

IvanRotrekl commented 5 years ago

Hi, I have noticed scheduled task failing silently under Mura 7.1 when sitemap location is set to the site folder. Sitemap generation from admin worked fine.

When I tried to run the URL generated by the scheduled task directly, I got a file not found error from the plugins's process/main controlller.

It looks like the filename and rc.filePath variables are calculated here by relying on site directory path being /{siteid}. Actually, in Mura 7.1 it is /sites/{siteid}.

https://github.com/blueriver/MuraGoogleSitemaps/blob/eabcde41cdeea7103ffbe20091e00f49239982c8/process/controllers/main.cfc#L37 https://github.com/blueriver/MuraGoogleSitemaps/blob/eabcde41cdeea7103ffbe20091e00f49239982c8/process/controllers/main.cfc#L38

It could be fixed simply by replacing #siteid# with #siteConfig.getAssetPath()# and would work with both Mura 7.1 and older Mura versions.

Regards

Ivan