search

bluerobotics / BlueOS

The open source platform for ROV, USV, robotic system operation, development, and expansion.
https://blueos.cloud/docs/
Other
135 stars 71 forks source link

Bridget: hot-plugging is not working #1016

Open Williangalvani opened 2 years ago

Williangalvani commented 2 years ago

We had a report that upon disconnecting and reconnecting a serial port, the bridge isn't rebuilt

patrickelectric commented 2 years ago

The latest version of bridges now has an option to disable auto disconnect and also detect serial disconnection. https://github.com/patrickelectric/bridges/commit/16a7b82658823c1b9f119c887be38ea0475eb75e https://github.com/patrickelectric/bridges/commit/459cf353ad7a7b5ace8fe6f941e8601caff62c87

Will create a PR for blueos soon.

rafaellehmkuhl commented 2 years ago

@patrickelectric was this solved with the recent PRs?

patrickelectric commented 2 years ago

No, this makes possible for bridget to restart bridges if something goes wrong on the serial port.

patrickelectric commented 2 years ago

bridges itself now just closes if a serial port is disconnected.