Closed matt-bathyscope closed 2 years ago
Thanks for the report @matt-bathyscope!
Is the idea to require Bullseye?
Is the idea to require Bullseye?
bullseye is not required, but if I recall correctly, is the last version that still has support to the raspberry legacy mode. That's necessary since the new mode does not have official support from gstreamer, making it not possible for us to stream. So, if you plan to use only USB cameras and not the CSI Raspberry camera, you should be fine.
Bug description
The
install.sh
script assumes your Raspberry Pi is already on a Debian Bullseye variant of Raspberry Pi OS. This may not be the case if you're upgrading an older companion. Theget_legacy
function ofraspi-config
appears to only be present on the Bullseye variants which causes an error on Buster variants.If the intention is to have everyone on Bullseye then maybe fail sooner with a message to update. If Buster is meant to still be supported, I recommend gating the
raspi-config nonint get_legacy
command (https://github.com/bluerobotics/BlueOS-docker/blob/master/install/install.sh#L168) with a check to see if you're actually on Bullseye. This compatibility step is not needed on Buster.I'm happy to PR this to either fail early if you're not on Bullseye, or add a check
lsb_release -sc
isbullseye
before the camera compatibility command is run.Steps to reproduce
Run the install script per README
Primary pain point(s)
Installer script doesn't succeed on Raspberry Pi OS unless you're on Bullseye.
Prerequisites