bluerobotics / BlueOS

The open source platform for ROV, USV, robotic system operation, development, and expansion.
https://blueos.cloud/docs/
Other
123 stars 67 forks source link

vehicle setup: advanced ArduSub lights configuration #2370

Open patrickelectric opened 4 months ago

patrickelectric commented 4 months ago

Can we add a slider for the steps? And min/max PWM limits?

Could also be nice to have a little graph showing the steps visually (with display options for both linear and Lumen-exponential brightness outputs).

It might make sense to have the channel controls in the top row, and then the steps slider + graph in a second row (instead of the current approach with everything in a single row).

Thinking something like this:

image

Originally posted by @ES-Alexander in https://github.com/bluerobotics/BlueOS/issues/2368#issuecomment-1930744278

ES-Alexander commented 4 months ago

For clarity, we might want the light type selection options to be Servo (Lumen) and Duty-Cycle (LED).

There's some info in this forum comment for implementing the duty-cycle approach - I can't remember if the PWM frequency is determined from the RC_SPEED or SERVO_RATE parameter (if it's even configurable for all flight controller boards - not sure). Note that a minimum of 1 µs may be required (rather than 0) so it doesn't skip the bottom step, but that should be confirmed.