search

bluerobotics / BlueOS

The open source platform for ROV, USV, robotic system operation, development, and expansion.
https://blueos.cloud/docs/
Other
123 stars 67 forks source link

core: frontend: health: GpsTrayMenu: Update description to contain number of satellites #2726

Closed patrickelectric closed 1 week ago

Williangalvani commented 1 week ago

I think we should check for the MAV_SYS_STATUS_SENSOR_GPS bit in MAV_SYS_STATUS_SENSOR_GPS's "onboard_control_sensors_present" field

patrickelectric commented 1 week ago

I think we should check for the MAV_SYS_STATUS_SENSOR_GPS bit in MAV_SYS_STATUS_SENSOR_GPS's "onboard_control_sensors_present" field

What should we do with it ? This is just an information that a GPS is connected, but no further information. No status, number of satellites and etc. Is that better than GPS_RAW_INT/GLOBAL_POSITION_INT ?

Williangalvani commented 1 week ago

I think we should check for the MAV_SYS_STATUS_SENSOR_GPS bit in MAV_SYS_STATUS_SENSOR_GPS's "onboard_control_sensors_present" field

What should we do with it ? This is just an information that a GPS is connected, but no further information. No status, number of satellites and etc. Is that better than GPS_RAW_INT/GLOBAL_POSITION_INT ?

hide the icon entirely if there is no gps connected, such as in rovs

patrickelectric commented 1 week ago

I think we should check for the MAV_SYS_STATUS_SENSOR_GPS bit in MAV_SYS_STATUS_SENSOR_GPS's "onboard_control_sensors_present" field

What should we do with it ? This is just an information that a GPS is connected, but no further information. No status, number of satellites and etc. Is that better than GPS_RAW_INT/GLOBAL_POSITION_INT ?

hide the icon entirely if there is no gps connected, such as in rovs

But we are doing that already here.

image

patrickelectric commented 1 week ago

Btw, this PR fix a corrente problem where the icon show in a vehicle that does not have a GPS, UI discussions can happen in an issue.