bluerobotics / BlueOS

The open source platform for ROV, USV, robotic system operation, development, and expansion.
https://blueos.cloud/docs/
Other
168 stars 80 forks source link

installer: Only remove blueos-related images #2747

Open matt-bathyscope opened 5 months ago

matt-bathyscope commented 5 months ago

Current behaviour

I just ran the installer on a Pi that had an older version of BlueOS as well as my own docker container and the installer script blew away all images, not just the BlueOS related images. This is not ideal UX and maybe we should have a warning before doing it.

Expected or desired behaviour

Either warn before deleting running containers and cached images, or only remove BlueOS-related docker containers and images.

Prerequisites

joaoantoniocardoso commented 5 months ago

Hi! Right now you can manually remove all BlueOS images and export NO_CLEAN=1 before calling the installer

patrickelectric commented 5 months ago

We should add the default value for the variable in the header of the file and also document it in the readme.