search

bluerobotics / BlueOS

The open source platform for ROV, USV, robotic system operation, development, and expansion.
https://blueos.cloud/docs/
Other
123 stars 67 forks source link

frontend: add failsafe configurations #2748

Open Williangalvani opened 1 week ago

Williangalvani commented 1 week ago

This implements the (for me) more relevant/important failsafes image

helps #2723

patrickelectric commented 6 days ago

We should ask for marketing to come up with the icons if we want that in the next stable.

patrickelectric commented 5 days ago

We should ask for marketing to come up with the icons if we want that in the next stable.

SMS will work on that, we can merge after stable

ES-Alexander commented 5 days ago

SMS will work on that, we can merge after stable

@patrickelectric feedback so far has been positive on the existing hand-drawn designs. I've mentioned that I can neaten them up or change them to not drawn ones, but that hasn't been requested or desired by the five people who've responded.

Daniel did mention that it might be a bit weird to have a different style only in this page, but we can have a think about whether that's ok since we don't have such images anywhere else, or if we perhaps want to add those kinds of images to some of our other pages as well :-)

patrickelectric commented 5 days ago

SMS will work on that, we can merge after stable

@patrickelectric feedback so far has been positive on the existing hand-drawn designs. I've mentioned that I can neaten them up or change them to not drawn ones, but that hasn't been requested or desired by the five people who've responded.

Daniel did mention that it might be a bit weird to have a different style only in this page, but we can have a think about whether that's ok since we don't have such images anywhere else, or if we perhaps want to add those kinds of images to some of our other pages as well :-)

I agree, the feedback from SMS was: "I think we could probably keep the essence of these icons, but maybe tweak them just a little!"

patrickelectric commented 4 days ago

@ES-Alexander @Williangalvani after talking with @rjehangir, we agreed that the current icons can be used, but sms will be working to make them sharp. Meanwhile, if the PR gets ready, we can merge it before 1.3 stable.

ES-Alexander commented 3 days ago

@Williangalvani there are cleaned up SVGs downloadable in the Issue, which can be switched to if you want.