ES-Alexander
commented
5 days ago Confirmed the arrow colour is fixed 👍
That said, there are some other small compass page issues that should probably get fixed in the same PR:
- [ ] The Pixhawk only has one listed compass, but still shows an arrow for compass 2, just set pointing north
- it should be hidden if there is no compass for it
- [ ] The "Compass Learn" dropdown description has a typo where it says "...then driver the vehicle around" (should be drive), and is missing the final period
- [ ] The "Compass Learn" popup window has the large vehicle calibration title
- [ ] The second word in the "Compass Learn" popup description is unnecessarily capitalised ("A Valid position" should be "A valid position")
- [ ] The "Large Vehicle Calibration" popup is using the "Compass Learn" popup's description
- [ ] There's no "back" / "undo" option when you select to enter custom coordinates in the "Large Vehicle Calibration" popup, so to use the GeoIP coordinates from that point you need to either refresh the whole page or copy them from the section above
- It might make more sense to not have the two buttons at all, and just start with the custom coordinates view but pre-filled with the GeoIP coordinates, so the user can either click "use these coordinates" straight away, or change them first if they want custom ones
- To make it extra obvious we could change the confirmation button text to be "Use GeoIP coordinates" when the input coords match the GeoIP ones, and then change it to "Confirm custom coordinates" when they don't match
- [ ] The background of all the compass calibration popup window title bars is hardcoded to the light-mode grey
patrickelectric
fix #2757