search

bluerobotics / BlueOS

The open source platform for ROV, USV, robotic system operation, development, and expansion.
https://blueos.cloud/docs/
Other
131 stars 69 forks source link

core: frontend: vehicle-setup: failsafes: visual improvements #2788

Open patrickelectric opened 2 weeks ago

patrickelectric commented 2 weeks ago 
          Looking great! :D

Only remaining comments are:

  1. It'd be nice to have a non-zero minimum horizontal margin around the cards, to prevent this from being possible: Screenshot 2024-07-05 at 10 07 04 AM
    • Perhaps we could have a reusable component for at least most/all of the cards within the Vehicle Setup page, to avoid additional PRs like #2638 being necessary?
  2. I think low battery is more important than the pressure/temp ones, and it would also look better if it was moved up to directly after the Leak Sensor (so when they're paired up the pressure/temp ones go together and can shrink the card height) Screenshot 2024-07-05 at 10 15 05 AM
  3. I'm not sure how the flat blue background is applied, but it might be worth showing the page background gradient, or at least making sure the flat background colour is defined in terms of the theme variables

I do think 1 and 2 are worth fixing, but none of those points are critical, so approving now.

Again, excellent work with this - it'll hopefully make the failsafes more approachable and widely used :-)

Originally posted by @ES-Alexander in https://github.com/bluerobotics/BlueOS/pull/2748#pullrequestreview-2159582059

ES-Alexander commented 1 week ago