bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://docs.bluerobotics.com/ardusub-zola/software/control-station/Cockpit-1.0/overview/
Other
42 stars 18 forks source link

Implement new UI to Configurations - general #1002

Closed ArturoManzoli closed 2 weeks ago

ArturoManzoli commented 3 weeks ago

Main features:

Regular size screens: https://github.com/bluerobotics/cockpit/assets/14910201/c8c67845-fcf5-43a7-8d1f-d2e2477f4e4a

Very small screens: https://github.com/bluerobotics/cockpit/assets/14910201/63df7c5b-4140-4fb6-99f5-6a55bec1110e

Closes #969

ArturoManzoli commented 2 weeks ago

For some reason I'm trying to enter the configuration menus here and they are not opening. Do you know what can it be?

There was a file change missing. Should be fixed now.

Its been a pain to center the icons contained inside the circular buttons (specially when shifting between screen sizes and OS) on main menu and some inside the components, like the help button-icons. Could you be very meticulous in correcting these alignments? Since you run Chrome on a Mac, it will be important to know how the alignments are there.

BTW.: When shifting between resolutions/screen-sizes on chrome dev tools, please refresh the cockpit. Some responsive triggers are in stores and need that to work.

patrickelectric commented 2 weeks ago

@ArturoManzoli it appears that a rebase is necessary in this PR.

rafaellehmkuhl commented 2 weeks ago

Just noticing that this auto-close from Github without allowing the PR to be reopen is a limitation from Github itself that happens when one push-forces to a branch linked to a closed PR.

Unfortunately we didn't know about this limitation and had to reopen the PR. The new one can be found here.

More about the limitation here.