search

bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://blueos.cloud/cockpit/docs
Other
72 stars 22 forks source link

Add instantaneous power and total power consumption #1370

Closed rafaellehmkuhl closed 1 month ago

rafaellehmkuhl commented 1 month ago

Adds instantaneous power and total power consumption to the BatteryIndicator widget.

https://github.com/user-attachments/assets/fa160e7c-e3cf-4678-9d9c-069902542f88

image

Fix #1368

rafaellehmkuhl commented 1 month ago

Code looks good, but there is a small issue on the functionality.

When selecting 'Show voltage and current', the indicator shows voltage and current. When nothing is selected, it shows Power consumption;

But when both are selected, it freaks out and try to show both! :)

Maybe the solution is a radio button, that would make only one selected.

This is the expected behavior actually😅

The user has the option to only show one of the screens, or to automatically alternate between them.

I will put a lower limit on the interval thought, so it doesn't go crazy.

ArturoManzoli commented 1 month ago

Code looks good, but there is a small issue on the functionality. When selecting 'Show voltage and current', the indicator shows voltage and current. When nothing is selected, it shows Power consumption; But when both are selected, it freaks out and try to show both! :) Maybe the solution is a radio button, that would make only one selected.

This is the expected behavior actually😅

The user has the option to only show one of the screens, or to automatically alternate between them.

I will put a lower limit on the interval thought, so it doesn't go crazy.

Ahh, nice that it can alternate! I couldn't tell because the alternating rate in my case, somehow, was very very short.

Cool though. I'll recheck

rafaellehmkuhl commented 1 month ago

I see where was the issue with the toggle interval. As I never had this version of the mini-widget on cockpit before, the toggling time was set to undefined or null (the number input was empty when I selected both checkboxes).

It did happen again with the last version you just updated. There was no default value for the toggling time. Probably would happen with the users on their first time running the new mini-widget.

Indeed. I was auto-setting the default interval, but not changing the visual input. Solved.