bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://blueos.cloud/docs/extensions/cockpit/1.0/overview
Other
54 stars 20 forks source link

Manual control of boats requires mavlink functions on buttons #348

Open Williangalvani opened 1 year ago

Williangalvani commented 1 year ago

Also note that Rover does not have firmware-side handling of buttons. they should all be handled with mavlink.

This image implies that is happening:

Screenshot 2023-06-02 at 18 11 18

but nothing can be configured anywhere

rafaellehmkuhl commented 1 year ago

Better stating what is happening:

Rover does not use the buttons on MANUAL_CONTROL messages for vehicle control, and instead use only the axes inputs from there, and expect commands to be sent separately, on dedicated mavlink command messages (e.g.: MAV_CMD_COMPONENT_ARM_DISARM).

I'm adding arm, disarm and mode toggle on #349 to start, but will create a separated protocol for custom mavlink commands.

rafaellehmkuhl commented 8 months ago

@Williangalvani are there other necessary commands for the Boat besides Arm/Disarm, or are all the other optional and we can implement in a generic MAVLinkCommand action?

Williangalvani commented 8 months ago

mode changes would be nice too, I think arming/disarming and mode changes are the essential ones

ES-Alexander commented 7 months ago

MAV_CMD_DO_SET_RELAY would also be useful, as raised in this forum thread, but like with mode changes it's better suited to an approach that allows some configuration (like @rafaellehmkuhl's suggested "generic MAVLinkCommand action"), so we don't have to manually define every option as a separate action.