search

bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://docs.bluerobotics.com/ardusub-zola/software/control-station/Cockpit-1.0/overview/
Other
43 stars 18 forks source link

When reconnecting to a WebRTC stream, 2 streams are requested. #812

Open joaoantoniocardoso opened 4 months ago

joaoantoniocardoso commented 4 months ago

How to reproduce

  1. turn on the vehicle w/ mavlink-camera-manager running
  2. open cockpit, wait for it to load the stream
  3. Check webrtc-internals. 1 stream is running.
  4. go to BlueOS, restart MCM
  5. go back to cockpit, wait for the stream to connect
  6. check webrtc-internals again, 2 new streams are running, and 1 (the old) is finished
rafaellehmkuhl commented 4 months ago

Interesting!

When you say the old one is finished, what do you mean exactly? It will keep consuming client resources, but not network bandwidth? Does it reflect somehow on the usage of the stream? Maybe connected to #775?

And on the MCM side, what's the outcome of this?

joaoantoniocardoso commented 4 months ago

The old one is finished from the MCM side (following the steps, we killed MCM, right?), and it is shown on webrtc-internals as a finished WebRTC stream.

The 2 new ones (there should be only 1 new one) will double the resources used by MCM and the network.

And.. I think it's not related to https://github.com/bluerobotics/cockpit/issues/775

rafaellehmkuhl commented 4 months ago

Oh, got it! There are two actually running now. Damn. Will take a look at this.