search

bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://docs.bluerobotics.com/ardusub-zola/software/control-station/Cockpit-1.0/overview/
Other
46 stars 19 forks source link

[WebRTC] There should be no stun/turn servers by default #916

Closed joaoantoniocardoso closed 2 months ago

joaoantoniocardoso commented 3 months ago

Proposed change

  1. There should be no default stun/turn servers
  2. The stun and turn servers should be configurable

Why?

Although stun/turn servers are usually good because they provide additional ICE candidates, they are potentially routed through the internet (especially if using public stun servers like the ones from Google -- our current behavior), which can degrade significantly the perceived performance, adding latency and/or stuttering, depending on the quality of both connections (vehicle to internet, internet to Cockpit).

Relevant section of the code: image

rafaellehmkuhl commented 3 months ago

Agree.

@Williangalvani you were the one using those, right? How could we do this configuration in a way that fits your needs?

joaoantoniocardoso commented 3 months ago

Agree.

@Williangalvani you were the one using those, right? How could we do this configuration in a way that fits your needs?

...perhaps a BlueSim configuration?

rafaellehmkuhl commented 3 months ago

Agree. @Williangalvani you were the one using those, right? How could we do this configuration in a way that fits your needs?

...perhaps a BlueSim configuration?

Yup. My question is how would Cockpit receive this. One way would be through query parameters, as will has implemented on PR #669.