search

bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://docs.bluerobotics.com/ardusub-zola/software/control-station/Cockpit-1.0/overview/
Other
43 stars 18 forks source link

Download of longer videos (49min) takes a lot of time to start #929

Closed rafaellehmkuhl closed 3 weeks ago

rafaellehmkuhl commented 2 months ago

The video processed fine and is viewable in the built-in player, but when it was time to download it, it didn't work.

image

The snackbar appeared and that was it. Downloading smaller videos (1min) worked fine. After trying to download this larger one, trying again to download the smaller one also failed.

rafaellehmkuhl commented 2 months ago

Update: after about 2 minutes, Chrome started to download it (as it is a local file, it downloaded instantly).

As a user, I would just assume it failed. We should consider that as a critical bug.

rafaellehmkuhl commented 1 month ago

Just tested and a 10 minutes video is taking 15 seconds to start downloading. 40 seconds for a 22min video.

rafaellehmkuhl commented 1 month ago

From my tests, what is taking a lot of time is the process of zipping the files. It's strange, since this didn't use to take long on the old implementation, but the code does not seen to have changed significantly on this part.

rafaellehmkuhl commented 3 weeks ago

Got the problem: in the old implementation we had the option to download only the video file separately, without zipping, and this was fast. When zipping, even in the old implementation, it was taking the same time.

PS: git is a magical tool.