search

bluerobotics / cockpit

An intuitive and customizable cross-platform ground control station for remote vehicles of all types.
https://blueos.cloud/docs/extensions/cockpit/1.0/overview
Other
54 stars 20 forks source link

Implement new main menu and responsivity logic #985

Closed ArturoManzoli closed 3 months ago

ArturoManzoli commented 4 months ago

Running on different device screen resolutions: image image

image image

Closes #968

rafaellehmkuhl commented 4 months ago

This looks nice! Will start the reviewing right up on!

ArturoManzoli commented 3 months ago

The misalignment of the icons wasn't present on the browser used during development. It is probably Mac-related. Anyway, I refactored the centering logic, and it should now be centered on all Chrome browsers. Please retest it.

Regarding the configuration menu items not being clickable, this is normal for now. Only the menu has been implemented so far. The configuration screens are being implemented in different tasks.

rafaellehmkuhl commented 3 months ago

Regarding the configuration menu items not being clickable, this is normal for now. Only the menu has been implemented so far. The configuration screens are being implemented in different tasks.

Got it! In this case, can you open a new branch (e.g.: "interface-rework"), and configure those interface pull requests to be merged to this branch, and not to master? This way we don't have to hold the approval/merge of the PRs because of this type of situation. Otherwise we will get to a situation close to the one we had during the video-recorder/video-lib-modal implementation, were we couldn't release new beta versions of Cockpit till everything was merged, because we merged a pull request that left some things open for the next one.