search

bluerobotics / companion

Companion computer startup scripts and examples
https://www.ardusub.com/operators-manual/companion-web.html
GNU General Public License v3.0
48 stars 54 forks source link

.companion.rc: re-enable ping mavlink driver #314

Closed Williangalvani closed 4 years ago

Williangalvani commented 4 years ago

since https://github.com/ArduPilot/ardupilot/commit/4b16271b3df99991259ffd314acab7bf7635c1a7 we no longer use it for control in depth-hold. Re-enabling it allows users to read the altitude in QGC.

The driver is required to populate the rangefinder fact in qgc: Screenshot from 2020-02-20 17-29-18

jaxxzer commented 4 years ago

What happens if a user updates companion but continues running ardusub 3.5?

patrickelectric commented 4 years ago

@Williangalvani since ardusub 4.0 has ping1d support, is there a reason to use it via companion and not connect ping1d directly in the pixhawk ? I just don't see the point.

kklemens commented 4 years ago

So there's two range/distance sensor groups in QGC, which one do we want customers to use? I think the DistanceSensor one so customers can set their ping orientation however they want. I know some want to face forwards. 2020-02-20_1410

jaxxzer commented 4 years ago

@Williangalvani since ardusub 4.0 has ping1d support, is there a reason to use it via companion and not connect ping1d directly in the pixhawk ?

@patrickelectric if we connect directly via pixhawk, the data is not available to ping-viewer.