bluerobotics / companion

Companion computer startup scripts and examples
https://www.ardusub.com/operators-manual/companion-web.html
GNU General Public License v3.0
48 stars 54 forks source link

Ping-enumerator can try to link two devices to the same /dev/serial/ping endpoint #338

Closed Williangalvani closed 2 years ago

Williangalvani commented 4 years ago

If two pings with the exact firmware and ID are connected, the ping-enumerator will try to link them to the same endpoints: https://github.com/bluerobotics/companion/blob/master/tools/ping_enumerator.py#L67-L72

The correct solution is to not have two devices with the same ID, but we should also handle the issue by adding a suffix (_2) to the link