Somehow initialize ping_message function to avoid magic numbers.

bluerobotics / ping-cpp

C++ API implementation of ping-protocol

12 stars 11 forks source link

Somehow initialize ping_message function to avoid magic numbers. #2

Open patrickelectric opened 5 years ago

patrickelectric commented 5 years ago

https://github.com/bluerobotics/ping-viewer/pull/522/files#r297255444

jaxxzer commented 5 years ago

This is the intended use case of this constructor. I can define on my own a ping message and populate it/access it by hand. The type of application is less common, as in this never-documented legacy use-case, or if I just wanted to experiment with firmware without modifying three repositories in the build system.