search

bluerobotics / ping-cpp

C++ API implementation of ping-protocol
12 stars 11 forks source link

add HAL to deployment, ship with CMakeLists file #35

Closed oKermorgant closed 2 years ago

oKermorgant commented 2 years ago

Hi,

When trying to use the deployment branch it seems that the hal folder is needed in ping-device.cpp. This PR adds this folder to the branch, and also comes with a CMakeLists.txt to compile the whole deployment library.

incebellipipo commented 2 years ago

This issue is important but I think the solution should be different. This repository uses Travis ci tool. Those lines should be modified I guess. Further comments are required from the authors.

https://github.com/bluerobotics/ping-cpp/blob/0e2b6599e1c9e0b593851af807c14ee6c270399d/tools/travis-ci-script.sh#L20-L21

patrickelectric commented 2 years ago

Hi @incebellipipo your approach is correct, it should be something closer to it.

oKermorgant commented 2 years ago

Hi, Sorry I have no experience with Travis CI and do not see how the branches are setup with regards to CI.

incebellipipo commented 2 years ago

We can turn this issue into a draft. I can take it on from now.

incebellipipo commented 2 years ago

I've made some changes but it should be discussed fairly. The changes I propose is in this repository

The resulting "deployment" branch looks like this.

Those lines did the trick:

This repository includes commit 6a9db50 as well. Here you can check.

However, I noticed that system continues to complain since generators are also not included in the deployment branch. Including generator python scripts would defy the very reason of having a "deployment" branch I thought. So I change the CMake logic a bit so that if the generated files are there it doesn't conduct the generation step. Proposed changes:

incebellipipo commented 2 years ago

Checkout PR https://github.com/bluerobotics/ping-cpp/pull/39

ES-Alexander commented 2 years ago

Work continued in #39