search

bluerobotics / ping-viewer

Ping Viewer is an open-source application to view and record data from the Blue Robotics Ping Echosounder and Ping360 Scanning Sonar.
https://docs.bluerobotics.com/ping-viewer/
GNU General Public License v3.0
40 stars 38 forks source link

Support telemetry in Ping360 replays #1009

Open ES-Alexander opened 2 years ago

ES-Alexander commented 2 years ago

Summary

Telemetry should be integrated in replays via tlogs in the same way as live viewing supports it.

Additional information

Live viewing allows auto-rotation via telemetry integration, but it's not possible to link a tlog file when doing replays, so the initial correctly-rotated display can only be seen live. This means visual inspection and analysis after a dive requires recording the screen, which seems unnecessary when both relevant data streams are also already being recorded.

Including telemetry in replays also makes it possible to compare display options given the same set of inputs, which can be important when determining the usefulness of a given setting.

ES-Alexander commented 2 years ago

+1 requested in this forum post: https://discuss.bluerobotics.com/t/ping-360-video-overlay/10966

ES-Alexander commented 2 years ago

Kind of an alternative approach to #948

ES-Alexander commented 8 months ago

As an alternative it may be worth Ping Viewer recording the heading it receives from the autopilot as part of its binary data logs. Maybe we could make a generic "sensor heading" message in the ping-protocol to support this, and just convert the received MAVLink messages to that for logging purposes?

That wouldn't be as temporally accurate as doing a replay from an autopilot DataFlash log, for example, but would at least allow replaying the scan as it was displayed at the time of recording. It could also be useful for more generically supporting other data input types (e.g. if someone wants to manually record their ping data through a script and play it back with Ping Viewer later).