bluerobotics / ping-viewer

Ping Viewer is an open-source application to view and record data from the Blue Robotics Ping Echosounder and Ping360 Scanning Sonar.
https://docs.bluerobotics.com/ping-viewer/
GNU General Public License v3.0
40 stars 38 forks source link

github: Change redistributed DLLs #1024

Closed joaoantoniocardoso closed 2 years ago

joaoantoniocardoso commented 2 years ago

Fixes #1018

In summary:


note: Marked as draft until artifact validation.

patrickelectric commented 2 years ago

Let me know if you can validade the artifacts. @ES-Alexander, if you have anyone with the same issue, please let us know if it fixes.

joaoantoniocardoso commented 2 years ago

@patrickelectric yeah, I just did that.

From the built artifact, on a fresh Windows 10 install, it is working just fine:

image

Also, DLLs' version seems to be just the latest distributed from Microsoft:

image


The artifact is validated, so I'm opening this PR for review.