search

bluerobotics / ping-viewer

Ping Viewer is an open-source application to view and record data from the Blue Robotics Ping Echosounder and Ping360 Scanning Sonar.
https://docs.bluerobotics.com/ping-viewer/
GNU General Public License v3.0
40 stars 38 forks source link

Fix link-local detection #1061

Closed Williangalvani closed 1 year ago

Williangalvani commented 1 year ago

fix #1054 fix #1059

this might mean we're dropping support for ubunut 18.04? not sure. but we at least get a build. 18.04 was dropped from actions.

patrickelectric commented 1 year ago

@Williangalvani check ci code style check

patrickelectric commented 1 year ago

@Williangalvani

/home/runner/work/ping-viewer/ping-viewer/src/sensor/ping360asciiprotocol.h:49: warning: Member removeLeadingZerosFromIP(const QString &line) (function) of class Ping360AsciiProtocol is not documented. Missing documentation in code!