search

bluesabre / menulibre

MenuLibre is an advanced menu editor that provides modern features in a clean, easy-to-use interface.
https://bluesabre.org/menulibre
GNU General Public License v3.0
212 stars 17 forks source link

Parsing error for `Type` value #66

Closed rootkea closed 3 years ago

rootkea commented 4 years ago

Hello!

I'm using menulibre 2.2.1 on Ubuntu 20.04 LTS.

It seems that menulibre doesn't recognize Service as a valid Type value since it shows following parsing error: 

Type value is invalid - currently 'Service', should be 'Application'

But as per the desktop entry spec, Service is a valid type along with other 2 types mentioned there.

Kdeconnect uses .desktop file with Type=Service.

Also, what about Link (type 2) and Directory (type 3)? With current implementation, Libremenu will report the parsing error for .desktop files with Type=Link or Type=Directory - both valid type values.

Looks like this is the line of code in question: https://github.com/bluesabre/menulibre/blob/c617e6bb49c2744904b4c6af3db1ad62dbdb15a0/menulibre/util.py#L647

Thanks!

bluesabre commented 3 years ago

Thanks for the bug report! Corrected in the above commit.