Zooming the image doesn't take up the entire workspace

bluescan / tacentview

An image and texture viewer for tga, png, apng, exr, dds, pvr, ktx, ktx2, astc, pkm, qoi, gif, hdr, jpg, tif, ico, webp, and bmp files. Uses Dear ImGui, OpenGL, and Tacent. Useful for game devs as it displays information like the presence of an alpha channel and querying specific pixels for their colour.

ISC License

344 stars 33 forks source link

Zooming the image doesn't take up the entire workspace #30

Closed ClangPan closed 2 years ago

ClangPan commented 2 years ago

Yeah, I wanted the displayable area to maintain aspect under zoom...but also not sure how much I like it either -- it especially breaks down viewing extremely narrow images.

bluescan commented 2 years ago

Commit 77e5b26ab10bfff5ac46a6f09aee12024dfbf98a : Default to NOT use a fixed aspect work area. It is now an option (FixedWorkAreaAspect) to turn it on in the 'Display' tab of the preferences (the 'Display' tab used to be called 'Background'). Also fixed a background drawing bug that was sometimes showing a pixel-width line outside of the image.

This commit also includes removal of some questionable UV margin code. I'm going to let this settle a bit b4 closing. Have tested rotate, crop, zoom, pan -- but not thoroughly.

ClangPan commented 2 years ago

Mmm, what is FixedWorkAreaAspect supposed to do exactly? The same zoom as before? Because turning it on and off doesn't seem to change anything, even after rebooting the program (apart from sometimes shifting the image a couple of pixels to the left / right).

The new zoom behavior works great however, haven't seen any weird behaviors on that front.

bluescan commented 2 years ago

Yup! It was supposed to give the old behaviour back. Fixed in e60c3f7dad15054e45db898d48410ffaad7e5acd Thanks for testing.