[Bug] Filename encoding problems - Githubissues

bluescan / tacentview

An image and texture viewer for tga, png, apng, exr, dds, pvr, ktx, ktx2, astc, pkm, qoi, gif, hdr, jpg, tif, ico, webp, and bmp files. Uses Dear ImGui, OpenGL, and Tacent. Useful for game devs as it displays information like the presence of an alpha channel and querying specific pixels for their colour.

ISC License

344 stars 33 forks source link

[Bug] Filename encoding problems #43

Closed kutu closed 8 months ago

kutu commented 2 years ago

Tacent won't open file if it has Cyrillic letter (it opens with blank window). try rename a file to ы.png

Tacent title bar incorrectly display filenames with chars that not English.

bluescan commented 2 years ago

KubuntuCyrillic_Screenshot_20220618_134124 From Kubuntu

bluescan commented 2 years ago

This one's from Windows 11.

kutu commented 2 years ago

i use windows 10 did you use precompiled version? i use tacent v1.0.27

if i open image with double click, it just blank if i try drag and drop image, tacent opens next image in folder

bluescan commented 2 years ago

Note, the 2 screens above are without making any changes/fixes... so might need some more information. It is worth noting that in windows I do have the following option set (as I needed utf-8 to show u properly in console output):

bluescan commented 2 years ago

I'll try the release of 1.0.27. I don't have windows 10 tho.

bluescan commented 2 years ago

Works locally with the released 1.0.27. Also tried double-clicking and drag-and-drop without issue. I'll need to try (but can't right now) with the checkbox above un-checked. glfw expects the title in utf-8 encoding which is what is being passed.

kutu commented 2 years ago

after enabling "beta" option, it started to work as expected

bluescan commented 2 years ago

Yeah. Hopefully you're happy with this for now (as a bonus, you can now see more unicode characters in the command prompt etc). In truth you should not really need to have this option checked if the viewer and its base libraries were calling the UNICODE and _UNICODE versions (UTF16 on windows) OS calls everywhere... It's a bit of work to fix, but I'll leave this issue open for now. Thanks for the report.

bluescan commented 2 years ago

As of 03e7cb466a62cfacdf205ba0a9dc6bc25d5dc973 the Beta flag is no longer necessary.

kutu commented 8 months ago

file name in title is showing correctly
drag and drop image to tacentview is working
double click on file with Cyrillic symbols is still not working (I'm not using "Beta" flag). It opens next file in folder. Accidentally if there is only one file in folder, then it opens file that I wanted

using tacentview_1.0.43.zip

bluescan commented 8 months ago

Hi kutu. Thanks for the report. I'll re-open this. Looks like it's 'nearly' all working ;)

bluescan commented 8 months ago

Fixed in 6006aa0738fc062f03206c921aa3a9e271ca8543 'Beta' checkbox no longer necessary to have the viewer open files with cyrillic characters by double-clicking.