search

bluesheeptoken / CPT

Compact Prediction Tree: A Lossless Model for Accurate Sequence Prediction (cython implementation)
https://cpt.readthedocs.io/en/latest/
MIT License
41 stars 7 forks source link

Error in the implementation #84

Closed bluesheeptoken closed 3 years ago

bluesheeptoken commented 3 years ago

As per the paper, the definition of a subsequent sequence is the the subsequence starting after the last item in common with S.

This sentence is misleading. According to the source code, the subsequent of the sequence ABAC with respect to AB should be AC instead of C.

bluesheeptoken commented 3 years ago

Fixed by #86. It will be released in the next release